#15351: import_statements sometimes fails
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner: vdelecroix
Type: defect | Status: positive_review
Priority: major | Milestone: sage-6.2
Component: misc | Resolution:
Keywords: | Merged in:
Authors: Vincent Delecroix | Reviewers: Nathann Cohen
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/improve_import_statements | b880d2d735a3651d06e83f40dfadd51df18bb2ee
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Hello,
> Really I tried, and I don't get a word of what the main function does.
> [...]
Ok. I had many comments into the code, especially about what the variables
are.
> - Why is `exclude_pattern` overwritten when module is `None` ?
Because you can crash Sage (really):
{{{
sage: from sage.misc.dev_tools import load_submodules
sage: load_submodules(sage.libs)
load sage.libs.coxeter3.coxeter_group...failed
load sage.libs.cremona.homspace... suceeded
...
load sage.libs.singular.groebner_strategy... suceeded
sage: quit # BOOOOOM
}}}
> - "Here we test some instances::" is followed by nothing
I removed it.
> - Why should calling `import_statement` on a module raise an exception ?
What if I do not know where `graph_decompositions` is located ?
> {{{
> sage: import_statements("graph_decompositions")
> ...
> ValueError: the object '<module 'sage.graphs.graph_decompositions' from
'/home/ncohen/.Sage/local/lib/python2.7/site-
packages/sage/graphs/graph_decompositions/__init__.pyc'>' is a module
> }}}
Fixed.
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/15351#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
