#14095: SymmetricGroup as a proper WeylGroup
-------------------------+-------------------------------------------------
Reporter: | Owner: sage-combinat
nthiery | Status: needs_review
Type: | Milestone: sage-6.2
defect | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Travis Scrimshaw
combinatorics | Work issues:
Keywords: | Commit:
days45, coxeter | 3f77996aca99c269302db147dc4826cc51e8a5bf
Authors: | Stopgaps:
Frédéric Chapoton |
Report Upstream: N/A |
Branch: |
u/tscrim/14095 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by tscrim):
* commit: c97072a455237563dea59c12bfb071dc9b355b7e =>
3f77996aca99c269302db147dc4826cc51e8a5bf
* branch: u/chapoton/14095 => u/tscrim/14095
* reviewer: => Travis Scrimshaw
Comment:
Looks good overall. I've caught one more `unit` in the category
`AffineWeylGroups`. I've also marked some tests as `# long time` in
`permgroup_named.py` since basic testing of that file was taking forever.
Plus I've done some other tweaks to that file (gawd that file needs
cleanup though). So if you're happy with my changes then positive review.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=4df5a62603403e67f85103b25a869c32933d5418
4df5a62]||{{{One more unit() to one().}}}||
||[http://git.sagemath.org/sage.git/commit/?id=3f77996aca99c269302db147dc4826cc51e8a5bf
3f77996]||{{{Some misc cleanup to permgroup_named.py.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/14095#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
