#15898: UniqueFactory for DirichletGroup
-------------------------------------+-------------------------------------
Reporter: saraedum | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.2
Component: modular forms | Resolution:
Keywords: | Merged in:
Authors: Julian Rueth | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/saraedum/ticket/15898 | 55bf7be591e181fc7016a0422307881a8360c57f
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by pbruin):
Looks good (although I haven't tested it yet). Two questions:
- why include `base_ring` in `key`? It can be recovered as the parent of
`zeta`, and isn't used in `create_object()`.
- could you add a doctest to show that it works as intended, i.e. really
creates a unique instance?
--
Ticket URL: <http://trac.sagemath.org/ticket/15898#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
