#16102: Including code to compute Lyapunov exponents for translation surfaces.
-------------------------------------+-------------------------------------
       Reporter:  Fougeroc           |        Owner:
           Type:  task               |       Status:  new
       Priority:  major              |    Milestone:  sage-6.2
      Component:  geometry           |   Resolution:
       Keywords:                     |    Merged in:
  lyapunov_exponents,                |    Reviewers:  Vincent Delecroix
  translation_surfaces, geometry,    |  Work issues:
  sagedays57                         |       Commit:
        Authors:  Fougeroc           |  048431e8b786dd92e21b59620c8863482a90f970
Report Upstream:  N/A                |     Stopgaps:
         Branch:                     |
  u/Fougeroc/Lyapunov_exponents_for_translation_surfaces|
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by vdelecroix):

 * reviewer:   => Vincent Delecroix


Comment:

 Hi Charles,

 Here are some remarks.

 About syntax:

 - remove trailing whitespaces
 - documentation lines should be at most 80 characters long
 - all functions and methods must have an EXAMPLES block. In order
   to see how much work you have to do, you can use
   {{{sage -coverage MY_FILE}}}.
 - The block RETURN should be OUTPUT

 General design:

 - It would be more coherent to have an object "covering of stratum".
   In a concrete way it would be a permutation of interval exchange
   (that may be considered as a marking) together with a covering data.
   We do not care that much about a concrete interval exchange in your
 code.
 - avoid using import from `sage.all`, to know from which module you need
   to import an object you can use `import_statements(MY_OBJECT)`. For more
   info look at `import_statements?`.


 About code:

 - there are already several things in Sage for interval exchange
   transformations and strata. It would be simpler to use them.
 - you must put a comment about `precision = 128` and
   `diff_sum_seuil = 2**(-precision+20)`. Even better, remove them.
 - in order to fit nicely with other components of Sage, you should
   separate the code (like your class `IntExchange`) and the examples
   (like the functions `EKZ_example`).

--
Ticket URL: <http://trac.sagemath.org/ticket/16102#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to