#8828: Lower height bound for elliptic curves
-------------------------------------+-------------------------------------
Reporter: robertwb | Owner: cremona
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.2
Component: elliptic curves | Resolution:
Keywords: | Merged in:
Authors: Robert Bradshaw, | Reviewers: Peter Bruin
John Cremona | Work issues:
Report Upstream: N/A | Commit:
Branch: | 5a9b58a34ad4b8e24c17828031417af15e862759
u/pbruin/8828-lower_height_bound | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by pbruin):
* commit: 361590b875996d1a5eadd350e110052341603ca8 =>
5a9b58a34ad4b8e24c17828031417af15e862759
* branch: u/cremona/ticket/8828 => u/pbruin/8828-lower_height_bound
* reviewer: => Peter Bruin
Comment:
Could you please check if you agree with the changes in the new branch
(which is based on yours)? Here is a summary of the changes:
- The first commit ("reviewer patch") consists mostly of formatting
changes, spelling fixes and Python style issues. It also adds the new
files to the reference manual. Because of this I had to change one of the
references [TT] to [T]. I also changed [Cremona2010] to [CT] to be more
consistent.
- The documentation of the existing method `NumberField_absolute.places()`
is wrong; in fact it never returns an embedding into `RIF` or `CIF`, it
just uses these to determine the required precision if `prec=None`. I
have not changed the documentation; it could be done in an additional
commit here or in a new ticket. For the new method
`RationalField.places()`, I just added the `prec=Infinity` option.
- For consistency, `RDF` is now used instead for all bounds (there were
two places where `RR` was used).
- The two coefficients of the Laurent series of the Weierstrass p-function
that are needed can be obtained more easily as suitable multiples of the
usual modular forms ''c'',,4,, and ''c'',,6,,.
- Added documentation for the functions mentioned in comment:32.
All tests pass, so if you are happy with the changes you can set this to
positive review.
--
Ticket URL: <http://trac.sagemath.org/ticket/8828#comment:38>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
