#15030: Switch standard 2D plotting from `fast_float` to `fast_callable`
-------------------------------------+-------------------------------------
Reporter: eviatarbach | Owner:
Type: defect | Status: positive_review
Priority: major | Milestone: sage-6.2
Component: graphics | Resolution:
Keywords: plot | Merged in:
Authors: Eviatar Bach | Reviewers: Ralf Stephan
Report Upstream: N/A | Work issues: compare patch with
Branch: | alternative by ppurka
u/rws/switch_standard_2d_plotting_from__fast_float__to__fast_callable_|
Commit:
Dependencies: | 7a9e07abeaf14171706e407173a342810031e200
| Stopgaps:
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Eviatar Bach', 'oldvalue': ''}):
* keywords: => plot
* reviewer: => Ralf Stephan
* commit: => 7a9e07abeaf14171706e407173a342810031e200
* status: needs_work => positive_review
* author: => Eviatar Bach
Comment:
{{{
this patch
before
sage: timeit('plot(abs(log(x)), (x, -20, 20))') 11.4 ms
2.4
sage: timeit('circle((1,1), 1) + plot(x^2, (x,0,5))') 2.7 ms
2.3
sage: timeit('plot(x^2,(x,300,500),ticks=[None,50000])') 10.8 ms
9.4
sage: i = CDF.0 # define i this way for maximum speed.
sage: timeit('plot(lambda t: arg(zeta(0.5+t*i)),
1,27,rgbcolor=(0.8,0,0))')
52.2 ms
52.2
sage: timeit('plot([sin(n*x) for n in [1..4]], (0, pi))') 10.4 ms
10.2
sage: f = (2*x^3+2*x-1)/((x-2)*(x+1))
sage: timeit('plot([f, 2*x+2], -7,7, fill = {0: [1]})') 11.2 ms
11.1
}}}
so, in my opinion, there is only a slowdown where the original behaviour
was incorrect. It is not correct to say "This patch makes the symbolic
expression plots about five times slower."
I rebased the patch on 6.2.beta7. LGTM and tests fine in `plot/` and
`symbolic/`.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=7a9e07abeaf14171706e407173a342810031e200
7a9e07a]||{{{Trac 15030: replace fast_float with fast_callable in 2D
plotting}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/15030#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
