#16141: TransducerGenerators: New class, collecting common transducers
-------------------------------------+-------------------------------------
       Reporter:  cheuberg           |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  minor              |    Milestone:  sage-6.2
      Component:  combinatorics      |   Resolution:
       Keywords:                     |    Merged in:
  finite_state_machine               |    Reviewers:  Daniel Krenn
        Authors:  Clemens            |  Work issues:
  Heuberger, Sara Kropf              |       Commit:
Report Upstream:  N/A                |  86f84524b8ec4ef260c4ee5059ad2547244621b7
         Branch:                     |     Stopgaps:
  u/dkrenn/fsm/count_subblock_occurrences|
   Dependencies:  #15849, #16132     |
-------------------------------------+-------------------------------------
Changes (by dkrenn):

 * cc: dkrenn, skropf (removed)
 * reviewer:   => Daniel Krenn
 * branch:  u/cheuberg/fsm/count_subblock_occurrences =>
     u/dkrenn/fsm/count_subblock_occurrences
 * commit:  5d6576790363a5420da97d892020de617054dd71 =>
     86f84524b8ec4ef260c4ee5059ad2547244621b7


Comment:

 During the review, I rewrote parts of the docstring of the new generator
 file (inserted some text at the top; some minor changes). Please review
 those changes.

 For me this is a positive review (all tests pass, docs looking fine,
 coverage 100%), so if someones agrees with my changes, change the status
 of this ticket.
 ----
 Last 10 new commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=75aa9e18cff712cc97365838e8fcb8cd23fed5e6
 75aa9e1]||{{{corrected doctests (after change of output)}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=d18312e34348a90f56693e38784d063598e623fe
 d18312e]||{{{Merge branch 'fsm/state_color' into
 fsm/process_output_new}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=2d43fdda50bd5bad3b079e7861fbb725471d1d04
 2d43fdd]||{{{FiniteStateMachine: add failing doctests: non-hashable
 colors}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=547968aaa6eff0d3c96018bc72f080a188881134
 547968a]||{{{FiniteStateMachine.product_FiniteStateMachine, composition:
 fix unhashable colors}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=d51be51b8299930abc0e6b72700eca79cd978cfc
 d51be51]||{{{Automaton.determinisation(): docstring on hashable
 colors}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=c5dd860009a8fcab4988ab262b6ddd2aa99dc2c4
 c5dd860]||{{{Merge branch 'fsm/state_color' into
 fsm/process_output_new}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=70294bf300ddc75671aba8f517fd464aacaecbb4
 70294bf]||{{{trac ticket number added}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=4a53b0968fc2130b075533ad1c4aa1de9fdcf9e7
 4a53b09]||{{{Merge branch '#16132' into
 fsm/count_subblock_occurrences}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=5d6576790363a5420da97d892020de617054dd71
 5d65767]||{{{Edit doctests due to #16132 change.}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=86f84524b8ec4ef260c4ee5059ad2547244621b7
 86f8452]||{{{improved various docstrings in
 finite_state_machine_generators.py}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/16141#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to