#16142: transducers.add, transducers.sub, transducers.abs, transducer.operator: 
New
common transducers
-------------------------------------+-------------------------------------
       Reporter:  cheuberg           |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  minor              |    Milestone:  sage-6.2
      Component:  combinatorics      |   Resolution:
       Keywords:                     |    Merged in:
  finite_state_machine               |    Reviewers:  Daniel Krenn
        Authors:  Clemens            |  Work issues:
  Heuberger, Daniel Krenn, Sara      |       Commit:
  Kropf                              |  f344fd8f123082df19affa5d27776645fff57609
Report Upstream:  N/A                |     Stopgaps:
         Branch:                     |
  u/dkrenn/fsm/operator_transducers  |
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Clemens Heuberger, Daniel Krenn, Sara Kropf', 
'oldvalue': u'Clemens Heuberger, Sara Kropf'}):

 * cc: dkrenn, skropf (removed)
 * commit:  fdd778c80bc3c25f681ca05afc31c1a6117096fd =>
     f344fd8f123082df19affa5d27776645fff57609
 * reviewer:   => Daniel Krenn
 * branch:  u/cheuberg/fsm/operator_transducers =>
     u/dkrenn/fsm/operator_transducers
 * author:  Clemens Heuberger, Sara Kropf => Clemens Heuberger, Daniel
     Krenn, Sara Kropf


Comment:

 During review, I decided to extend {{{.operator}}} to arbirary opeators
 (not only binary). I've rewritten its docstring. I've also made a couple
 of changes in the docstings of {{{.add}}}, {{{.sub}}}, {{{.abs}}}.

 The patch looks good; doctests pass; docs checked. So this is a positive
 review for me, but please review my changes first.
 ----
 Last 10 new commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=547968aaa6eff0d3c96018bc72f080a188881134
 547968a]||{{{FiniteStateMachine.product_FiniteStateMachine, composition:
 fix unhashable colors}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=d51be51b8299930abc0e6b72700eca79cd978cfc
 d51be51]||{{{Automaton.determinisation(): docstring on hashable
 colors}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=c5dd860009a8fcab4988ab262b6ddd2aa99dc2c4
 c5dd860]||{{{Merge branch 'fsm/state_color' into
 fsm/process_output_new}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=70294bf300ddc75671aba8f517fd464aacaecbb4
 70294bf]||{{{trac ticket number added}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=4a53b0968fc2130b075533ad1c4aa1de9fdcf9e7
 4a53b09]||{{{Merge branch '#16132' into
 fsm/count_subblock_occurrences}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=5d6576790363a5420da97d892020de617054dd71
 5d65767]||{{{Edit doctests due to #16132 change.}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=e1bd1df10377ada8e64f60e34656fe50bdc974c8
 e1bd1df]||{{{Merge branch 'fsm/count_subblock_occurrences' into
 fsm/operator_transducers}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=3110f9d53c199521168ed8b2df193c94ac3e8c88
 3110f9d]||{{{Edit doctests due to #16132 change.}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=fdd778c80bc3c25f681ca05afc31c1a6117096fd
 fdd778c]||{{{generators.operator: final state state}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=f344fd8f123082df19affa5d27776645fff57609
 f344fd8]||{{{reviewer patch: improved function operator; extended and
 rewrote docstrings}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/16142#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to