#16179: Implement Algebra of Words and some linear operators
-------------------------+-------------------------------------------------
Reporter: | Owner:
virmaux | Status: needs_review
Type: | Milestone: sage-6.2
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers:
combinatorics | Work issues:
Keywords: | Commit:
Authors: | 5e4168c49dbe265a7ca6ece31e0a688bc3580b14
virmaux | Stopgaps:
Report Upstream: N/A |
Branch: |
u/virmaux/16179 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by vdelecroix):
Hi Aladin,
You did good about the tests in the documentation! As I am (as well as
many others) not familiar with algebras it would be nice to explain what
are the `e`, `f`, `zeta` and `sigma` operators in the docstring of the
methods. (I like learning math by digging in Sage documentation but hate
having to guess what are the specifications of a function)
For the design, most piece of code related to categories (which intend to
be generic code) must go inside sage/categories or for some rare case in
sage/structure. You decided to implement the category of your object as a
subclass of itself... which means that the code is '''not''' generic. So I
would not put that as category code but directly inside the Element. If
you have a strong argument about creating a category for the `FreeAlgebra`
please explain it on both this ticket and the file where the code belongs
to. On the other hand, in his axioms related peregrinations in #10963,
Nicolas proposed to have a `.Free()` (meaning that I would be able to do
`Groups().Free()` to choose my category). So your code might move to
somewhere more appropriate in the future.
There already is a `FreeAlgebra` in `sage.algebras.free_algebra`. What I
would naturally do is to move your `ElementMethods` as methods of
`FreeAlgebraElement` in `sage.algebras.free_algebra_element`. If you are
not happy with the current `FreeAlgebra` which is rather old, it would be
nice to refresh it a bit.
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/16179#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.