#15880: fixed some bugs in heegner.py
-------------------------------------+-------------------------------------
       Reporter:  haochen_uw         |        Owner:  haochen_uw
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.2
      Component:  number theory      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:                     |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/haochen_uw/ticket/15880          |  be1e8a5c5af44ebf9645f89b29194a774b9ca6fc
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by was):

 * status:  new => needs_review


Comment:

 REFEREE:

   - this branch is a mess, including stuff involving deleting info.plists
 and stuff.  Make a completely new clean branch.

   - The complicated-looking algorithm that I had implemented, which this
 patch deletes, is very, very efficient.  Since it is correct in the case
 when they're coprime, keep it in that case, and only use your (probably
 very) slow algorithm in the other case.  And put a note in that the other
 one might be slow (or is slow -- based on a benchmark with big p,e)... and
 somebody will make it fast someday.

--
Ticket URL: <http://trac.sagemath.org/ticket/15880#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to