#16181: inject_shorthands broken since 6.2beta8
-------------------------------------+-------------------------------------
Reporter: darij | Owner:
Type: defect | Status: needs_info
Priority: critical | Milestone: sage-6.2
Component: misc | Resolution:
Keywords: globals, | Merged in:
inject_shorthands, regression, | Reviewers: Travis Scrimshaw
Authors: Darij Grinberg | Work issues:
Report Upstream: N/A | Commit:
Branch: | 0b8ed458f20f651b1087da7eae3d182c5801e540
public/combinat/inject_shorthands | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by vbraun):
* status: positive_review => needs_info
Comment:
* Can we not leave commented-out lines lying around?
* IMHO the check should just be
{{{
if G.get("__name__", None) == "__main__":
}}}
and not look at `__package__`. The topmost `'__main__'` frame is our
guy, duh. Also this won't trip over similar issues if some frame doesn't
have `__name__`.
* The new doctest is just like doctests that we already have, it doesn't
add anything new.
--
Ticket URL: <http://trac.sagemath.org/ticket/16181#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
