#12437: lcalc defines default values for functions outside of declarations
--------------------------------------+----------------------------------
Reporter: ohanar | Owner: GeorgSWeber
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.2
Component: packages: standard | Resolution:
Keywords: | Merged in:
Authors: | Reviewers:
Report Upstream: N/A | Work issues: Create a new spkg.
Branch: | Commit:
Dependencies: #12681 | Stopgaps:
--------------------------------------+----------------------------------
Comment (by leif):
Replying to [comment:11 ohanar]:
> Your patch looks like a subset of mine.
Yes. My primary goal was to make Lcalc work with GCC; I'll take a closer
look at other changes later.
Adding `void` to the `friend` declaration of `reset()` is certainly
correct (although slightly unrelated to what the ''name of the patch''
suggests, on the broader topic of ''this'' ticket, namely making Lcalc's
code build with `clang`).
In the other hunks, you just removed default parameters from
''definitions'', but did not move them to corresponding ''declarations''
(probably because there aren't any, which is something I'll have to
check). But from at least one comment, it looks like those parts were
"dead" code anyway.
--
Ticket URL: <http://trac.sagemath.org/ticket/12437#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
