#14799: Power series rings should have a change_var method
-------------------------------------+-------------------------------------
       Reporter:  robharron          |        Owner:  AlexGhitza
           Type:  enhancement        |       Status:  positive_review
       Priority:  minor              |    Milestone:  sage-6.2
      Component:  algebra            |   Resolution:
       Keywords:  power series,      |    Merged in:
  variable name                      |    Reviewers:
        Authors:                     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  39328941dde7533d5bfa028a068c1d75e4f32c6a
  u/rws/ticket/14799                 |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by rws):

 * status:  needs_review => positive_review
 * commit:  79c7b73fb3c0122458df056ea35fe0b8946de32e =>
     39328941dde7533d5bfa028a068c1d75e4f32c6a


Comment:

 LGTM. Please try to work with the development branch. I rebased your
 branch on 6.2.beta8. I also added a small reviewer's patch to correct the
 doc line according to the imperative form (which is the Sage convention,
 see http://sagemath.org/doc/developer/coding_basics.html#docstring-markup-
 with-rest-and-sphinx). Finally, please add your real name as author to
 this ticket.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=c9b0c7eff44fd9c94bd480fa46aa6af902e05b52
 c9b0c7e]||{{{Merge branch 'develop' into t/14799/ticket/14799}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=39328941dde7533d5bfa028a068c1d75e4f32c6a
 3932894]||{{{14799: reviewer's patch: cosmetics}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/14799#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to