#14690: Useless memory allocation in listing neighbors of a graph
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner: jason, ncohen, rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-
Component: graph theory | duplicate/invalid/wontfix
Keywords: sparse graph, | Resolution:
allocation | Merged in:
Authors: Vincent Delecroix | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_work => needs_review
* milestone: sage-6.2 => sage-duplicate/invalid/wontfix
Old description:
> This patch exist because I am an idiot. I reviewed #14659 and did not
> notice that the creation of the list of neighbors actually allocates an
> array! So #14659 only solves half of the problem.
>
> The patch here remediates to the problem by adding an attribute `up` for
> the node of the binary tree (`SparseGraphBTNode`) that allows to do depth
> first search without storing anything.
New description:
This patch exist because I am an idiot. I reviewed #14659 and did not
notice that the creation of the list of neighbors actually allocates an
array! So #14659 only solves half of the problem.
The patch here remediates to the problem by adding an attribute `up` for
the node of the binary tree (`SparseGraphBTNode`) that allows to do depth
first search without storing anything.
Once #16005 is merged there is no need for that ticket.
--
--
Ticket URL: <http://trac.sagemath.org/ticket/14690#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
