#16214: Bug in is_hamiltonian: non-simple digraphs
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_work
Type: | Milestone: sage-6.2
defect | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers: Vincent Delecroix
theory | Work issues:
Keywords: | Commit:
Authors: | b055425a32af29a6e624a1dbef0f25dc577951f7
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
public/16214 |
Dependencies: |
#16210 |
-------------------------+-------------------------------------------------
Comment (by vdelecroix):
Replying to [comment:24 ncohen]:
> Oh. You are right there, a 0 should mean 0 and nothing else. There was
also this problem of NetworkX graph whose default edge label is a `{}`, it
caused us some trouble. I think we should write "l if l is not None else
1". But really, changing those None to 1 is already going too far to
repair a badly formatted input `:-/`
Yes. Doing work in the back of the user is not good practice. So
possibilities are
- 1) "1 if l is None else l" (we save one word with that version)
- 2) simply remove weight
I am in favor of 2). I did not check if the algorithm actually work if
there are some `0`, do you know if it does?
--
Ticket URL: <http://trac.sagemath.org/ticket/16214#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
