#10732: computing support of sum of two divisors doesn't work due to careless
error
-------------------------------------+-------------------------------------
Reporter: was | Owner: AlexGhitza
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.2
Component: algebraic | Resolution:
geometry | Merged in:
Keywords: | Reviewers: Peter Bruin
Authors: Alex Ghitza | Work issues:
Report Upstream: N/A | Commit:
Branch: | 375d57301c07ce04a7e90809a57bc958a38b10c6
u/AlexGhitza/ticket/10732 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by pbruin):
* reviewer: => Peter Bruin
Comment:
Replying to [comment:10 AlexGhitza]:
> I agree that this would be better, however Sage can't yet deal with
divisors containing non-rational points (see the TODO in the docstring of
{{{Divisor_curve}}} in {{{sage/schemes/generic/divisor.py}}}).
Wow, and there doesn't even seem to be a ticket for it! I'm not sure if I
agree with the TODO; I would say a divisor is a sum of prime divisors
(closed points of the scheme), and if you want arbitrary sums of
''L''-rational points you have to base change to ''L''.
> How about a comment in the new code saying that we should use
{{{irreducible_components()}}} as soon as non-rational points can be dealt
with? I'd rather not postpone fixing an existing issue while we wait for
new functionality that could take a while to arrive.
That is a good idea. Could you also delete the trailing whitespace in the
first empty line after the function? Then you can set it to positive
review.
--
Ticket URL: <http://trac.sagemath.org/ticket/10732#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
