#16216: Improve PEP8 compliance: replace "== None" by "is None"
-------------------------------------+-------------------------------------
Reporter: wluebbe | Owner:
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-6.2
Component: build | Resolution:
Keywords: pep8 | Merged in:
Authors: Wilfried Luebbe | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/wluebbe/ticket/16216 | 1219d56b731119122356714ed4d26ae33c63cd5d
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by leif):
Replying to [comment:23 vdelecroix]:
> 1) As I already told you, the substitutions made bad things to the
documentation. Hopefully, in very few places.
Yep, at least where "is None" isn't typeset as code.
And I also wouldn't touch most of the ''comments''.
[[BR]]
> 2) You start removing unnecessary parenthesis. First of all it is not
the job of that ticket. Secondly, one can arguably says that code is more
readable with more parenthesis. So revert all those changes. If you want
to remove parenthesis (which I think is a bad idea in general) then open a
discussion on sage-devel and then a ticket if a consensus is reached.
I'm in general ok with changing the "C style" `if (cond):` and `while
(cond):` to usual Python syntax (without ''outer'' parentheses), but I
agree that this should be done on another ticket, especially since
currently only ''some'' instances (namely those in or near the context of
other changes) get "normalized".
There are also a couple of conditions where I'd personally change ''the
order'' of evaluation, of the form `if <expensive_test> <and|or>
<cheap_test>:`, but that's also out of the scope of this ticket.
--
Ticket URL: <http://trac.sagemath.org/ticket/16216#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
