#16266: FiniteStateMachine: option to show empty final word out labels
-------------------------------------+-------------------------------------
       Reporter:  dkrenn             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.2
      Component:  combinatorics      |   Resolution:
       Keywords:  finite state       |    Merged in:
  machine, latex                     |    Reviewers:  Clemens Heuberger
        Authors:  Daniel Krenn       |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  27c13be6f03ccc4422a3123a74a9d65b76b70850
  u/cheuberg/fsm/accepting_show_empty_final_word_out_1|     Stopgaps:
   Dependencies:  #16207, #16253     |
-------------------------------------+-------------------------------------
Changes (by cheuberg):

 * commit:  eed6553dce6cb612b27f6d128e38631ce5086237 =>
     27c13be6f03ccc4422a3123a74a9d65b76b70850
 * branch:  u/dkrenn/fsm/accepting_show_empty_final_word_out =>
     u/cheuberg/fsm/accepting_show_empty_final_word_out_1
 * reviewer:   => Clemens Heuberger


Comment:

 Reviewed, code is ok, doctests pass. It seems that the branch contains
 some non-pertinent tickets, so I cherry-picked your commit on a new
 branch, based only on #16253.

 Please cross-review.
 ----
 Last 10 new commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=1f14955f1ae2a8ba3d8d1c5dd0a9890a3cd82ae2
 1f14955]||{{{FiniteStateMachine._latex_: use tikz arrow style "latex"}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=56b1d48dfeef86415338ffe06f1de7ec6ef61142
 56b1d48]||{{{default accepting_distance=7ex because of $ in final
 output}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=a0d894ef1c76c66cc17382599492487549be9314
 a0d894e]||{{{Merge remote-tracking branch 'aau/fsm/asymptotic-moments'
 into fsm/latex-options-digits}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=8f4cd21127b2ad4a622cf9e02abd4d37eb2541dd
 8f4cd21]||{{{Merge remote-tracking branch 'aau/fsm/latex-options-digits'
 into fsm/final_output_construction}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=d5d08ccee022ab4d4e0502178d079d1ae34374a0
 d5d08cc]||{{{Deleted a check for consistency in _latex_}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=0469d11d6d267ce2b34f4ebb9610bb22f499fd68
 0469d11]||{{{reworded ValueError (joined sentences)}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=df6f9fb81cb5af8e4599d42402fec4f53ef95560
 df6f9fb]||{{{reviewer patch: line breaks in documentation}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=bbe08665bb5210b4d6365f09dd76b4d671ab6084
 bbe0866]||{{{reworded two docstrings}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=21392c5654e857c534bd812219665953841ad073
 21392c5]||{{{added doctests to FSMState.deepcopy to check that deepcopy of
 a property works}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=27c13be6f03ccc4422a3123a74a9d65b76b70850
 27c13be]||{{{implemented accepting_show_empty}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/16266#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to