#3021: add curl and divergence functions to vectors
-------------------------------------+-------------------------------------
       Reporter:  jason              |        Owner:  was
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.2
      Component:  calculus           |   Resolution:
       Keywords:                     |    Merged in:
        Authors:                     |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/robertwb/ticket/3021             |  4e34d0d90624c54e233be003c460c3bbaf6e3dcf
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by eviatarbach):

 I was just going to work on this today!

 I haven't tested the code, but looks good. Just a few things:

 1. Is there any reason why you're converting the variables to their string
 representations in `._variables()`?
 2. The parameter in `Expression.gradient` is called `variables`; I think
 it would be good to switch `vars` to `variables` for consistency.
 3. I think there should be test(s) for `.curl()` with the variables
 parameter.
 4. I believe the `raise TypeError, "curl only defined for 3 dimensions"`
 syntax is deprecated, and that the string should be passed as an argument.

--
Ticket URL: <http://trac.sagemath.org/ticket/3021#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to