#16284: Remove some deprecated code
-------------------------------------+-------------------------------------
Reporter: aapitzsch | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.2
Component: misc | Resolution:
Keywords: | Merged in:
Authors: André Apitzsch | Reviewers: Nathann Cohen
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/aapitzsch/ticket/16284 | 1fcbcacf0ac3ae2bc367e53a09fbf07e6af91236
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by aapitzsch):
Replying to [comment:4 ncohen]:
> Why don't you leave this {{{vertex_set = [] }}} where it is and define
{{{vertex_set=None}}} before, as it is the current default value ?
>
> Nathann
I tried this, but it also failed.
The problematic line in {{{src/sage/schemes/toric/divisor.py}}} is
{{{
SimplicialComplex([c.ambient_ray_indices() for c in negative_cones])
}}}
The passed list previously became {{{vertex_set}}} and now it becomes
{{{maximal_faces}}}.
So maybe we should do
{{{
#!diff
--- a/src/sage/homology/simplicial_complex.py
+++ b/src/sage/homology/simplicial_complex.py
@@ -816,21 +798,9 @@
C = None
+ vertex_set = maximal_faces
if maximal_faces is None:
vertex_set = []
maximal_faces = []
}}}
What do you think?
--
Ticket URL: <http://trac.sagemath.org/ticket/16284#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
