#15061: PARI and Singular can't handle all polynomial resultants
-------------------------------------+-------------------------------------
Reporter: robharron | Owner:
Type: defect | Status: positive_review
Priority: major | Milestone: sage-6.2
Component: algebra | Resolution:
Keywords: pari, resultant, | Merged in:
sylvester matrix | Reviewers: Martin von Gagern
Authors: Robert Harron, | Work issues:
Peter Bruin | Commit:
Report Upstream: N/A | 51523b10dd11ba8e7b0689b351130e7596decc23
Branch: | Stopgaps:
u/pbruin/15061-resultant |
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by gagern):
* status: needs_review => positive_review
* reviewer: => Martin von Gagern
Comment:
Replying to [comment:17 pbruin]:
> You can probably judge yourself if you have done the things suggested in
[http://www.sagemath.org/doc/developer/trac.html#reviewing-patches
"Reviewing Patches"] in the developer guide.
* `./sage -t --all --long`: done, no new errors
* `make` including documentation: done
* `./sage -docbuild reference pdf`: done
* `./sage -coverage src/sage/rings/polynomial/*.py{,x}`: Diff shows that
this now has 6 things less to complain about, and no new ones
I wonder whether the docs for `resultant` regarding “Implemented using
PARI’s polresultant function.” should get adjusted. On the other hand, I
doubt that detailing the possible choices of algorithm is worth the
effort.
> (Note in particular that you are supposed to run all doctests; things
can really break in unexpected places.)
Did so, and found #16285 in the process. But that's reproducible without
your change, so not your fault.
Shouldn't running the testsuite be handled by patchbot? Or hasn't that
been migrated to the git workflow yet?
--
Ticket URL: <http://trac.sagemath.org/ticket/15061#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
