#16211: Implement Hadamard 3-Designs
-------------------------+-------------------------------------------------
Reporter: knsam | Owner:
Type: | Status: needs_review
enhancement | Milestone: sage-6.2
Priority: minor | Resolution:
Component: | Merged in:
combinatorics | Reviewers: Nathann Cohen
Keywords: | Work issues:
Authors: | Commit:
Report Upstream: N/A | 417b95994e01af32167c8dff5488b6f8d6a1c84a
Branch: | Stopgaps:
u/knsam/16211 |
Dependencies: |
#16237 |
-------------------------+-------------------------------------------------
Changes (by ncohen):
* reviewer: => Nathann Cohen
Comment:
Hello !
Thank you for this ticket. Nothing wrong in the maths now that `4` is
excluded, so only administrative remarks
1) Better to keep the first line of the docstring short and informative.
And at most one line
2) There should be an INPUT section, even though most of the functions of
this file are a bit old and don't respect that
3) You can link toward the doc of other functions, so unless you wanted to
advertise the `designs.<tab>` thing it is better to use `:meth:` or
`:func:` instead of just giving the function's name. This appears as a
link in the final html doc
{{{ sage -docbuild reference/combinat html}}}
4) Link toward a reference entry : you needs a _ after the [ref].
5) The reference entry was badly formatted
6) I did not understand the use of `.parent()` in this context. I removed
it, and no problem. Integers are not so tricky that you need parents to
handle them
All this has been implemented in a public/16211. As usual, positive review
to your branch. If you agree with my changes (and change the branch's name
or add my commits to your branch) then you can set the ticket to
`positive_review`.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/16211#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
