#16252: optional doctest broken in oeis -------------------------------------+------------------------------------- Reporter: vdelecroix | Owner: vdelecroix Type: defect | Status: positive_review Priority: major | Milestone: sage-6.2 Component: documentation | Resolution: Keywords: oeis, doctest | Merged in: Authors: vincent delecroix | Reviewers: Wilfried Luebbe Report Upstream: N/A | Work issues: Branch: | Commit: u/vdelecroix/16252 | 6fa9592c2f7b19135b9a6baf54bcd64fc9f0352e Dependencies: #14567 | Stopgaps: -------------------------------------+------------------------------------- Changes (by wluebbe):
* status: needs_work => positive_review * reviewer: => Wilfried Luebbe Comment: Hi, just as you predicted ... {{{ ~/sage-6.2.rc0$ ./sage -t --optional=sage,internet src/sage/databases/oeis.py Running doctests with ID 2014-05-05-21-13-21-9a2728e4. Doctesting 1 file. sage -t src/sage/databases/oeis.py [259 tests, 74.00 s] ---------------------------------------------------------------------- All tests passed! ---------------------------------------------------------------------- Total time for all tests: 74.1 seconds cpu time: 1.4 seconds cumulative wall time: 74.0 seconds wluebbe@Willis-Ubuntu:~/sage-6.2.rc0$ ./sage -t --optional=sage,internet,webbrowser src/sage/databases/oeis.py Running doctests with ID 2014-05-05-21-16-48-fbdfca29. Doctesting 1 file. sage -t src/sage/databases/oeis.py ********************************************************************** File "src/sage/databases/oeis.py", line 637, in sage.databases.oeis.OEISSequence.__init__ Failed example: sfibo = oeis('A039834') # optional -- internet Expected nothing Got: Created new window in existing browser session. ********************************************************************** File "src/sage/databases/oeis.py", line 1735, in sage.databases.oeis.OEISSequence.programs Failed example: ee = oeis('A001113') ; ee # optional -- internet Expected: A001113: Decimal expansion of e. Got: Created new window in existing browser session. Created new window in existing browser session. A001113: Decimal expansion of e. ********************************************************************** 2 items had failures: 1 of 3 in sage.databases.oeis.OEISSequence.__init__ 1 of 7 in sage.databases.oeis.OEISSequence.programs [264 tests, 2 failures, 76.03 s] ---------------------------------------------------------------------- sage -t src/sage/databases/oeis.py # 2 doctests failed ---------------------------------------------------------------------- Total time for all tests: 76.1 seconds cpu time: 1.4 seconds cumulative wall time: 76.0 seconds }}} Therefore I say: the patch looks good! - Doctest with (optional) webbrowser Chromium is a different story. -- Ticket URL: <http://trac.sagemath.org/ticket/16252#comment:11> Sage <http://www.sagemath.org> Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, and MATLAB -- You received this message because you are subscribed to the Google Groups "sage-trac" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-trac+unsubscr...@googlegroups.com. To post to this group, send email to sage-trac@googlegroups.com. Visit this group at http://groups.google.com/group/sage-trac. For more options, visit https://groups.google.com/d/optout.