#16291: Fixing associativity of FormalCompositeMap
-------------------------------------+-------------------------------------
Reporter: sbesnier | Owner: sbesnier
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: categories | Resolution:
Keywords: associativity | Merged in:
FormalCompositeMap | Reviewers:
Authors: Sébastien Besnier | Work issues:
Report Upstream: N/A | Commit:
Branch: | 4e90074d27dcb6a6f0f67a8f67c387b75aa6a0cc
u/sbesnier/ticket/16291 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by pbruin):
Is this still meant as a draft as stated in the ticket description? I
think it looks good in general, but maybe you could improve the formatting
of the code and try to conform to the Python
[http://legacy.python.org/dev/peps/pep-0008/ style guide] and
[http://legacy.python.org/dev/peps/pep-0257/ docstring conventions].
In particular:
- use consistent spacing (including spaces after punctuation marks and no
spaces before them)
- do not put `if foo: bar` on a single line unless foo and bar are very
short
- docstrings should start with a single line, or two if really necessary;
four, as in `__getitem__()`, is definitely too many
Also, I recommend keeping the `first()` and `second()` methods, since they
are public and existing user code may depend on them.
--
Ticket URL: <http://trac.sagemath.org/ticket/16291#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
