#16348: Cdd linker path
-------------------------------------+-------------------------------------
Reporter: vbraun | Owner:
Type: defect | Status: positive_review
Priority: blocker | Milestone: sage-6.3
Component: build | Resolution:
Keywords: | Merged in:
Authors: Volker Braun | Reviewers: François Bissey
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vbraun/cdd_linker_path | 55d2466229dbb6e198e4979a46ce337f99991f93
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by fbissey):
* status: needs_review => positive_review
* reviewer: => François Bissey
Comment:
Replying to [comment:21 leif]:
> Replying to [comment:20 fbissey]:
> > To finish with the comments on distro unfriendliness we fortunately
start with upstream adding only the piece we deem necessary. We don't
start from the sage spkg unless there is no other sources around :)
>
> To clarify, I'm not against patching the autotools files, I'm against
mixing completely unrelated patches. Especially if we want to submit
''parts of it'' upstream. (And it's easy to make sure they get applied in
the correct order if at all relevant. Same for timestamps if patched
files depend on other patched files.)
>
> And I'm sorry to say, but unfortunately Gentoo still isn't the only
distro. ;-)
>
How very unfortunate ;) that's why I have to read rpm .spec files from
time to time and even troll debian sources.But that was a long and boring
dragging comment - the kind you make in the morning because you are
gathering your thoughts.
> Others prefer to have `patches/fix_upstream_bug_{foo,bar}.patch`,
`patches/add_sage_functionality_baz.patch` rather than
`patches/modifying_{this,that}_file_for_a_couple_of_reason_you_can_probably_guess.patch`.
>
> Even for just Sage, the former is by far more easy to maintain.
>
> [[BR]]
>
> > I am a bit uncomfortable with the way autotools patches are applied
and enforced but I can accept that. I am more to apply the full autotool
solution that could be pushed upstream if they were responsive rather than
the quick nice fix proposed by Leif.
> > So if I have a deciding vote I am going for Volker.
>
> You have it, just give it positive review if you really feel it's ''the
right thing''^TM^ to do. Also in the light of #15871.
>
> Although the Debianists should probably speak up, too.
I guess we would need to invite them next time ;)
In the absence of a nice way to run autoreconf and al. on pristine source
(as Gentoo would) it is good enough for me. What we should send upstream
and in which form is another discussion.
--
Ticket URL: <http://trac.sagemath.org/ticket/16348#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
