#12437: lcalc defines default values for functions outside of declarations
--------------------------------------+----------------------------------
Reporter: ohanar | Owner: GeorgSWeber
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.3
Component: packages: standard | Resolution:
Keywords: | Merged in:
Authors: | Reviewers:
Report Upstream: N/A | Work issues: Create a new spkg.
Branch: | Commit:
Dependencies: #12681 | Stopgaps:
--------------------------------------+----------------------------------
Comment (by leif):
Ok, so I've now created 7 new patches to fix all remaining clang/non-
GNU/C++11 issues with Lcalc (except for some deprecation warnings):
{{{
Makefile_2-dont_compile_C_with_CXXFLAGS.patch
lcalc-1.23-fix_VLA_1.patch
lcalc-1.23-fix_VLA_2.patch
lcalc-1.23-fix_control_reaches_end_of_non-void_fn.patch
lcalc-1.23-fix_typeof.patch
lcalc-1.23-missing_return_type.patch
lcalc-1.23_default_parameters_2.patch
}}}
But I'd prefer to put them on a single ticket, i.e., to either open a new
one, or repurpose one of the two existing ones. (But before doing so,
I'll anyway polish them a bit, and probably merge some of them into
another or into one of the existing ones.)
I did take a slightly different approach to variable-length arrays;
instead of using `std::vector<>`, I'm using `foo_t *_foo = new
foo_t[dim1*dim2*dim3]`, along with a macro `foo(i,j,k)` which maps the
indices to a single one, and of course added `delete [] _foo` where
necessary.
So far tested with GCC 4.4, 4.8 and 4.9, clang 3.4.1, and a couple of
`-std=...` variations.
--
Ticket URL: <http://trac.sagemath.org/ticket/12437#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
