#16379: Compute Hasse invariant over number fields and fix current
implementation
-------------------------------------+-------------------------------------
Reporter: annahaensch | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.3
Component: quadratic forms | Resolution:
Keywords: | Merged in:
Authors: Anna Haensch | Reviewers: Peter Bruin
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/annahaensch/ticket/16379 | 471f15734adb60b20b0bc3d6c37aeaa5c2c2e5f5
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by pbruin):
* reviewer: => Peter Bruin
Comment:
Looks good to me except for two minor points:
- it is best to keep existing doctests as far as possible; only add new
ones, and fix old ones if necessary instead of replacing them;
- your patch introduces trailing whitespace on several lines (use e.g.
`git diff --color develop...YOURBRANCH` to see this); this is discouraged,
so could you remove it if and when you make another commit?
(The patchbot encountered a doctest failure on 6.3.beta1, but it seems to
be unrelated to your patch.)
--
Ticket URL: <http://trac.sagemath.org/ticket/16379#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
