#16405: Cartesian product of rings
-------------------------------------+-------------------------------------
       Reporter:  nthiery            |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.3
      Component:  categories         |   Resolution:
       Keywords:  cartesian product  |    Merged in:
        Authors:  Nicolas M. ThiƩry  |    Reviewers:  Nathann Cohen
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/nthiery/cartesian_product_of_rings|  
8b547db0ecdae108a3fa94b69010b579edb0d149
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by ncohen):

 Helloooooooooooo !!

 Some comments/questions:

 - What are sub/neg doing in `AdditiveMagma().AdditiveUnital()` ?

 - consistancy -> consistency

 - class nesting is cool and everything but you have to scroll non-stop
 with
   stuff like emacs.... Do you have a trick to know in which
 sub/sub/sub/sub
   class you are writing your code ?

 - You implement the `neg` function for cartesian product of
 AdditiveInverse
   Magma, but don't you also need to say somewhere what exactly is the "1"
   element of a cartesian product of UnitalMagma ?

 - You do things like :
   {{{
 Magmas().Unital().Inverse()
   }}}

   It feels like the syntax should be `Magmas().Unital().Inverse()`, which
 would imply Unital. What do you think ?

 - maybe I misread but you seem to implement `__invert__` in
   `Magmas().Unital().CartesianProduct()`. Shouldn't it be several lines
 above, in
   `Magmas().Unital().Inverse().CartesianProduct()` ?

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/16405#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to