#16403: Rename Graph.to_partition
-------------------------+-------------------------------------------------
Reporter: | Owner: pdehaye
ncohen | Status: needs_work
Type: | Milestone: sage-6.3
defect | Resolution:
Priority: minor | Merged in:
Component: graph | Reviewers:
theory | Work issues:
Keywords: | Commit:
Authors: | 9f08c6b859a0fb853f69dbaedc73811740ee3e91
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
u/ncohen/16403 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by rws):
* status: needs_review => needs_work
* milestone: sage-duplicate/invalid/wontfix => sage-6.3
Old description:
> This function is very badly named and seems to only be there to add a
> statistic to find_stat, a project distinct from Sage.
>
> Unless there is a reason to add a function a function that associates
> "the partition produced by the cardinalities of the connected components
> of a graph" (knowing that such a function can be written with only one
> line of code), and unless there is a better name for it, I propose to
> behave as if this function should have never made it in Sage, and remove
> it.
>
> I believe that this function has been added without caring at all about
> whether this function would be useful to other Sage users, and ONLY
> because of FindStat. Unless proven otherwise, let's remove it.
>
> As discussed there one year ago https://groups.google.com/forum/#!topic
> /sage-devel/SnPfidRM9j8 and independently from the rewrite promised there
> https://groups.google.com/forum/#!topic/sage-combinat-devel/YRc1GWa3XBg I
> believe that this function should be removed.
>
> Nathann
New description:
Previous descripion was:
This function is very badly named and seems to only be there to add a
statistic to find_stat, a project distinct from Sage.
ncohen: Unless there is a reason to add a function a function that
associates "the partition produced by the cardinalities of the connected
components of a graph" (knowing that such a function can be written with
only one line of code), and unless there is a better name for it, I
propose to behave as if this function should have never made it in Sage,
and remove it.
I believe that this function has been added without caring at all about
whether this function would be useful to other Sage users, and ONLY
because of FindStat. Unless proven otherwise, let's remove it.
As discussed there one year ago https://groups.google.com/forum/#!topic
/sage-devel/SnPfidRM9j8 and independently from the rewrite promised there
https://groups.google.com/forum/#!topic/sage-combinat-devel/YRc1GWa3XBg I
believe that this function should be removed.
Nathann
--
Comment:
The ticket raised a point in my opinion, and what would be necessary is to
change its title/description and, accordingly, the resulting code.
--
Ticket URL: <http://trac.sagemath.org/ticket/16403#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
