#16410: Make combinatorial_map a no-op by default.
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner:
Type: enhancement | Status: new
Priority: major | Milestone: sage-6.3
Component: combinatorics | Resolution:
Keywords: | Merged in:
combinatorial_map, findstat | Reviewers:
Authors: Nicolas M. Thiéry | Work issues:
Report Upstream: N/A | Commit:
Branch: | 0cc67e94a1fa27e955b2820a7b0f729e3f8275f1
u/nthiery/make_combinatorial_map_a_no_op_by_default_| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by nthiery):
Replying to [comment:3 vdelecroix]:
> I do not like the fact that in order to use combinatorial maps we need
to modify the source code. The decorator is executed when the source code
is loaded, hence on startup. Turning it on inside a console would just be
a nightmare. This is a killer strategy: you simply removed combinatorial
maps from being usable.
I agree, it's unusable from a plain Sage. But it remains usable by
findstat and friends which, as far as I know, are the only serious use
cases so far, while removing the primary gripe against
`combinatorial_map`.
Note: if we really care about keeping `combinatorial_maps_in_class` in
working state because some people might have been using, we could, as
a temporary trick, have the decorator do
'f._is_combinatorial_map=True` before returning f, and have
`combinatorial_maps_in_class` check for this attribute.
> On the other hand, this ticket can be reviewed quickly compared to
#16408 (which needs some design discussions).
Precisely :-)
> We can let this one go and then start discussing #16408 but I think we
need more opinions on this.
By the way: how bad is it to merge this on into #16408? I am sorry to
be getting in your way ...
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/ticket/16410#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
