#16415: Ignore case in package directory
-------------------------------------+-------------------------------------
Reporter: vbraun | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: build | Resolution:
Keywords: | Merged in:
Authors: Volker Braun | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vbraun/ignore_case_in_package_directory|
9b315855498609b254807fc74fc3bcfcca57af6b
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by leif):
Replying to [comment:11 vbraun]:
> Besides not portable, its IMHO not readable.
Well, the `find` version above is portable, although I'd just use it to
get the folder name. (Or some flavour of {{{(cd * && basename `pwd`)}}}.)
> The whole contraption should be rewritten in Python with some proper
doctesting.
In Lisp, please.
[[BR]]
Anyway, I'd really explicitly check whether `src/` afterwards exists (and
is a directory); we already have
{{{
#!sh
echo "Finished extraction"
cd "$PKG_NAME"
if [ $? -ne 0 ]; then
echo >&2 "Error: after extracting, the directory $PKG_NAME does
not exist"
exit 1
fi
}}}
right below for legacy spkgs.
[[BR]]
Just out of curiosity: Which bash version(s) did the original change work
with?
I tried older (3.2.*) as well as newer (4.3.11*) bashs; with none of them
it worked.
--
Ticket URL: <http://trac.sagemath.org/ticket/16415#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
