#16445: load and attach need parentheses
-------------------------------------+-------------------------------------
Reporter: sanvila | Owner:
Type: defect | Status: needs_review
Priority: trivial | Milestone: sage-6.3
Component: documentation | Resolution:
Keywords: | Merged in:
Authors: Santiago Vila | Reviewers: Punarbasu Purkayastha
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/sanvila/load_and_attach_need_parentheses|
ea8341ca7809ead68fae313a2b93f856c2971ead
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Santiago Vila', 'oldvalue': ''}):
* status: new => needs_review
* reviewer: => Punarbasu Purkayastha
* author: => Santiago Vila
Comment:
Replying to [comment:8 sanvila]:
> I think that's all.
That's great! Many thanks. :-)
> BTW: Now this trac report has two git commits, but I assume this
documentation bug will be fixed by a single commit in sage master git. Is
there a way I can merge those commits into a single one to ease the work
of sage developers?
No, please don't try doing so. In this ticket it probably doesn't make
much of a difference if we combine commits or not. In general, it is
better to not combine them. Then we can follow the sequence of changes in
the ticket.
The second reason for not combining the patches is that once you make
something public, it is better not to change that. Someone else will have
checked out your changes, and if you overwrite it then it will mess up
their git.
I didn't realize until now that the ticket was still set to "new". In the
future, you should set the ticket to "needs review" so that someone can
come by and have a look. If it stays at "new", then the usual assumption
is that there are no patches waiting for review.
--
Ticket URL: <http://trac.sagemath.org/ticket/16445#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
