#16460: a cache for OA/TD/MOLS existence
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: u/ncohen/16460 | f23d39c13647376fcb12f2c1825a3053af976174
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Replying to [comment:4 ncohen]:
> Yo !
>
> > - the default for `min_false` should be `n+2`? No?
>
> Aahahah right. I had thought about this afterwards and forgot to change
it, but I had comforted myself before by figuring out that it had actually
no effect on the answers. Because "True" is tested before "False" `:-)`
> > - with the current implementation, the `_set_OA_cache` set a new value
to `_OA_cache[n]` even if nothing has changed. This is bad from the global
warming point of view.
>
> And you think that your added "if" have a zero cost ? To me it is rather
useless and adds lines for no point...
>
> > - it would be better that the keys and values are only Python `int` or
only Sage `Integer` but not a mix.
>
> I'm not sensible to these problems `:-P`
>
> > On the other hand, wouldn't it be better to have this in
`designs_pyx.pyx`?
>
> Ahahah. We are not there yet. There is a long road in front of us before
that this caching mechanism represent a non-negligible part of the
computations `:-P`
>
> Okay... Well, if you insist on having this "best" test I guess it can go
although really I don't see the point... Otherwise if you are okay with
not including it I would be glad to add to my branch the part of your
commit that converts k,n to Python 'int' if it makes you sleep easier.
Please convert to int '''and''' set the default `False` to `n+2`.
Otherwise, you assume that there is no projective plane except for prime
powers.
--
Ticket URL: <http://trac.sagemath.org/ticket/16460#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
