#16464: cyclotomic_cosets for any finite ring
-------------------------+-------------------------------------------------
Reporter: | Owner:
vdelecroix | Status: needs_review
Type: | Milestone: sage-6.3
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers:
number theory | Work issues:
Keywords: | Commit:
Authors: | f0474bb138221ffa139ede31f6e04ed47d02e6ea
Vincent Delecroix | Stopgaps:
Report Upstream: N/A |
Branch: |
public/16464 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by vdelecroix):
* status: needs_info => needs_review
* commit: 9b1544b90970887f5e22a4aa1e93db04cd18ce90 =>
f0474bb138221ffa139ede31f6e04ed47d02e6ea
* branch: u/vdelecroix/16464 => public/16464
Comment:
Replying to [comment:9 ncohen]:
> About this part of the code
>
> {{{
> + try:
> + return DuadicCodeEvenPair(F,Q,N)
> + except TypeError:
> + raise TypeError("No quadratic residue code exists for these
parameters.")
> }}}
>
> Is there any reason why your replaced the {{{if
not(is_a_splitting(Q,N,n))}}} by this try/catch ? What worries me is that
it could catch `TypeErrors` raised in `DuadicCodeEvenPair` that are real
bugs and not created by this {{{if not(is_a_splitting(Q,N,n))}}}.
Ok. I modified the function... the errors are clearer and there is no
try/except anymore.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=f0a29585467f32cc4b2311944a3e1ad5a9203fe9
f0a2958]||{{{trac #16464: Docstring work}}}||
||[http://git.sagemath.org/sage.git/commit/?id=f0474bb138221ffa139ede31f6e04ed47d02e6ea
f0474bb]||{{{trac #16464: be more careful with errors}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/16464#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
