#16361: OA(7,66), OA(7,68), OA(8,69), OA(7,74) and OA(8,76)
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: u/ncohen/16361 | 20ef21682cfe8b6532e2e2621b88d921236528f2
Dependencies: #16356 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Replying to [comment:10 ncohen]:
> Hello !
>
> > `incomplete_orthogonal_array`:
> >
>
> > - If `k=n+1` then we have a projective planes and all blocks
intersect... so there is no `OA(n+1,n) - 2.OA(n+1,1)`. I added the
appropriate test in `incomplete_orthogonal_array`.
>
> See `[1]`
What is `[1]`?
> > `OA_from_PBD`:
> >
> > - I changed the end of the if/elif to forward the non-existence (and
also avoid doctest error because of #16388)
>
> See below
>
>
> > see the changes on the branch `public/16361` (where #16461 is merged).
I was able to build the doc and all test pass...
> >
> > Do you have further remarks? Otherwise it deserves a positive review.
>
> Well... Actually, I think that you should not intercept all exceptions
in order to return specific error messages... I believe that you should
let the subfunction raise its own exception. That's going too far I think
`:-/`
>
> I believe that you should let the subfunction raise its exception. What
do you think ?
>
All right, but then you should put #16388 as a dependency and adapt the
doctests...
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/16361#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
