#16475: Bug in Gomory-Hu tree algorithm
-------------------------------------+-------------------------------------
Reporter: foosterhof | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: graph theory | Resolution:
Keywords: gomory hu tree | Merged in:
gomory-hu gomory_hu_tree | Reviewers:
Authors: | Work issues:
Report Upstream: N/A | Commit:
Branch: | 9326d1518c32d30978e7b4ce9e39720f1bf8083d
u/foosterhof/ticket/16475 | Stopgaps:
Dependencies: 12797 |
-------------------------------------+-------------------------------------
Comment (by ncohen):
Hello !
Just some cosmetic remarks :
- Set is *MUCH* slower than set or frozenset, so if you don't need Set for
a specific reason don't use it:
{{{
sage: %timeit Set(range(50))
10000 loops, best of 3: 29.1 µs per loop
sage: %timeit frozenset(range(50))
100000 loops, best of 3: 2.05 µs per loop
}}}
- It would be cool if you could add some comments about what the following
block of code does. Just a line or 5 words, i.e. something to say with
words what is happening there
{{{
+ C = {}
...
+ C[r] = C2[r]
}}}
Thanks for fixing that, btw `:-)`
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/16475#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
