#10519: analytic combinatorics: new code for computing asymptotics for
multivariate
generating functions
-------------------------------------+-------------------------------------
Reporter: araichev | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: combinatorics | Resolution:
Keywords: analytic | Merged in:
combinatorics, multivariate | Reviewers: David Loeffler
generating functions, asymptotics | Work issues: rebase
Authors: Alex Raichev | Commit:
Report Upstream: N/A | 7511d1454940e11462bf07452c745638fd48d95a
Branch: | Stopgaps:
public/combinat/analytic-10519 |
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Hi,
Just read the code and glance some remarks. The code looks very
interesting but I have some advices/questions.
- as a matter of uniformization class name are better expanded
(`FractionWithFactoredPolynomialDenominator` instead of `FFPD`)
- `cartesian_product_iterator` will be very soonly deprecated, so use
`product` from the Python `itertools` module instead.
- it is generally bad practice to have such a big import list at the
begining of the file (because of potential circular import). Moreover some
of them can be completely avoided: `L = FractionField(PolynomialRing(K,
indets))` can be `PolynomialRing(K, indets).fraction_field()`.
More seriously:
- I do not understand the specifications. It is said that the numerator
must be an element p of a 0 or 1 variate factorial polynomial ring R but
you have examples involving `cos(x)`. What is the underlying polynomial
ring in that case?
- repeating comment:59, Why there is a need for the class `FFDP`? Why
isn't it directly implemented as the level of fractions of polynomials? It
would makes sense to cache the factorization of the denominator if it is
required in several places, but I do not see the point of the `FFDP`
class.
- Some of the method needs definition: `critical_cone`,
`is_convenient_multiple_point`, ...
- Some of the method would better be hidden: `combine_like_terms`, ...
Best
Vincent
--
Ticket URL: <http://trac.sagemath.org/ticket/10519#comment:66>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
