#13053: wrong sign in square-free decomposition of polynomials over ZZ
---------------------------------------+----------------------------
       Reporter:  saraedum             |        Owner:  tbd
           Type:  defect               |       Status:  needs_review
       Priority:  major                |    Milestone:  sage-6.3
      Component:  factorization        |   Resolution:
       Keywords:  sd40.5 FLINT NTL ZZ  |    Merged in:
        Authors:  Julian Rueth         |    Reviewers:
Report Upstream:  N/A                  |  Work issues:
         Branch:                       |       Commit:
   Dependencies:                       |     Stopgaps:
---------------------------------------+----------------------------
Changes (by {'newvalue': u'Julian Rueth', 'oldvalue': ''}):

 * status:  needs_info => needs_review
 * author:   => Julian Rueth


Comment:

 I pushed a branch which fixes this. Here are some timings. Without my
 changes
 {{{
 sage: R.<x> = PolynomialRing(ZZ, implementation='FLINT')
 sage: f=(2*x^2 - 4*x^4 + 14*x^7)
 sage: %timeit f.content()
 1000000 loops, best of 3: 183 ns per loop
 sage: %timeit x.content()
 1000000 loops, best of 3: 165 ns per loop
 sage: f=R(0)
 sage: %timeit f.content()
 1000000 loops, best of 3: 108 ns per loop
 }}}
 With my changes
 {{{
 sage: R.<x> = PolynomialRing(ZZ, implementation='FLINT')
 sage: f=(2*x^2 - 4*x^4 + 14*x^7)
 sage: %timeit f.content()
 1000000 loops, best of 3: 194 ns per loop
 sage: %timeit x.content()
 1000000 loops, best of 3: 139 ns per loop
 sage: f=R(0)
 sage: %timeit f.content()
 1000000 loops, best of 3: 165 ns per loop
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/13053#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to