#16347: Wilson's constructions of OA with 2 truncated groups
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: u/ncohen/16347 | 0fa89d548f431a8929c76f3205bdb6c3779cf432
Dependencies: #16373 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
Yo !
> More reasonable review at `public/16347-bis`. If you like it enough, set
to positive review.
I agree with the latest two commits but when it comes to the modifications
made in `find_wilson_decomposition_with_two_truncated_groups` I believe
that you are really making the code harder to read for almost no
improvement. You add 6 lines to replace one, and this only to avoid
calling `orthogonal_arrays` several times, knowing that all calls would
answer instantly (they do the check that "n<=1 or k<n+1" each time).
When `n` is not a prime power, I expect that
`orthogonal_array(n+1,n,existence=True)` is much more costly than all
`orthogonal_array(n+1,n_prime,existence=True)` for `n_prime<n` combined
(all straightforward 'no').
Really, that's not where the performance is hidden. The next patch
improves things a lot, and the next patch on recursive constructions make
things a lot worse. There will be profiling to do there, but really that's
not where performance is to be found.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/16347#comment:44>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
