#13591: Improve padic add_bigoh
-------------------------------------------+-----------------------------
Reporter: saraedum | Owner: saraedum
Type: enhancement | Status: needs_review
Priority: trivial | Milestone: sage-6.3
Component: padics | Resolution:
Keywords: sd59 | Merged in:
Authors: Julian Rueth | Reviewers:
Report Upstream: N/A | Work issues:
Branch: u/saraedum/ticket/13591 | Dependencies:
Stopgaps: |
-------------------------------------------+-----------------------------
Changes (by saraedum):
* keywords: => sd59
* status: needs_work => needs_review
Old description:
> There are a few minor issues with {{{add_bigoh()}}} of the padics:
>
> I believe that all these should produce errors:
> {{{
> sage: K = ZpCR(3,20)
> sage: K.one().add_bigoh(-1)
> O(3^-1)
> sage: K = ZpCA(3,20)
> sage: K.one().add_bigoh(-1)
> O(3^0)
> sage: K = ZpFM(3,20)
> sage: K.one().add_bigoh(10)
> 1 + O(3^20)
> }}}
>
> Additionally, {{{add_bigoh()}}} doesn't work for infinity which can be
> annoying sometimes:
> {{{
> sage: K.one().add_bigoh(infinity)
> TypeError: unable to coerce <class 'sage.rings.infinity.PlusInfinity'> to
> an integer
> }}}
New description:
`add_bigoh()` handled negative inputs very inconsistently. Now it tries to
bring the element into the fraction field and apply `add_bigoh()` there.
Additionally, `add_bigoh()` did not work for infinity which can be
annoying sometimes:
{{{
sage: K.one().add_bigoh(infinity)
TypeError: unable to coerce <class 'sage.rings.infinity.PlusInfinity'> to
an integer
}}}
--
--
Ticket URL: <http://trac.sagemath.org/ticket/13591#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
