#16191: FiniteStateMachine: implement final_word_out
-------------------------------------+-------------------------------------
Reporter: cheuberg | Owner:
Type: task | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: finite state | Resolution:
machines | Merged in:
Keywords: | Reviewers: Clemens Heuberger
finite_state_machine | Work issues:
Authors: Sara Kropf | Commit:
Report Upstream: N/A | d1f3e216a8e8e1913c803ec27baadc789f7b2300
Branch: u/cheuberg/fsm | Stopgaps:
/final-word-out-problems |
Dependencies: #16206, #16207, |
#16253, #16145#16254 |
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Sara Kropf', 'oldvalue': ''}):
* commit: c3f2b335d22977e7ba2460cd9721553ca5274fbc =>
d1f3e216a8e8e1913c803ec27baadc789f7b2300
* reviewer: => Clemens Heuberger
* branch: u/skropf/fsm/final-word-out-problems => u/cheuberg/fsm/final-
word-out-problems
* author: => Sara Kropf
Comment:
I reviewed the patch. Builds, doctests pass. I added one commit with
rather minor changes (punctuation, indentation, {{{.. TODO::}}} tag) and
moved the new example from the private method
{{{_composition_explorative_}}} to the public method {{{composition}}}.
Please cross-review these changes and feel free to set the status to
positive_review.
----
Last 10 new commits:
||[http://git.sagemath.org/sage.git/commit/?id=13e000cfb0cb0bca6b631215c7195a963d9fb83b
13e000c]||{{{FSMState.copy also copies final_word_out}}}||
||[http://git.sagemath.org/sage.git/commit/?id=bcf330800da84450a35e3fd48ed7d59a67f179fb
bcf3308]||{{{Transducer.asymptotic_moments only accepts transducers with
all states final and transducers.GrayCode is now such a transducer.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=8d29348caeb62bc330638494de537c61fa044edd
8d29348]||{{{Correct TeX errors (raw string vs. string) in docstring (Gray
Code)}}}||
||[http://git.sagemath.org/sage.git/commit/?id=ae8ec6b18e2a26484393c752b30a117db2b858c6
ae8ec6b]||{{{Modified a few docstrings to reflect use of final output
word}}}||
||[http://git.sagemath.org/sage.git/commit/?id=492754259b2f7000b45da9d3ab8f610763421181
4927542]||{{{removed determine_alphabets=True from docstrings because it
is the default anyway}}}||
||[http://git.sagemath.org/sage.git/commit/?id=ba07d56515eecea78d1d09f7f4f11e04146e1494
ba07d56]||{{{Use iterators instead of lists}}}||
||[http://git.sagemath.org/sage.git/commit/?id=0be171e624bb02e87f203dec9026a02903987644
0be171e]||{{{Added examples for
FiniteStateMachine.equivalence_classes}}}||
||[http://git.sagemath.org/sage.git/commit/?id=95414f5844a038139157b53ec54e3b1935b5db88
95414f5]||{{{NotImplementedError in _composition_explorative_ if there are
final word outs}}}||
||[http://git.sagemath.org/sage.git/commit/?id=c3f2b335d22977e7ba2460cd9721553ca5274fbc
c3f2b33]||{{{corrected spacing}}}||
||[http://git.sagemath.org/sage.git/commit/?id=d1f3e216a8e8e1913c803ec27baadc789f7b2300
d1f3e21]||{{{trac #16191: Reviewer Patch: Move one example; spacing; typo;
punctuation}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/16191#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
