#16553: Clean IncidenceStructure
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.3
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: Nathann Cohen, | Work issues:
Vincent Delecroix | Commit:
Report Upstream: N/A | dffcc4a8118a8bc5d9dfa6c1ab1aabe7aaaaa25a
Branch: public/16553v2 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: needs_review => needs_work
Comment:
Short of those comments it looks good !!
Two questions:
- What about renaming `_point_index` to `_point_to_index` to make its
purpose clearer ?
- Should `block_sizes` return `map(len,self._blocks)` or wrap them in a
`set` ?
Too bad that it is not very easy to have everything work with a "copy"
argument `:-/`
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/16553#comment:117>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
