#16147: abs for elements of number fields provided with a complex embedding 
ignores
it
-------------------------------------+-------------------------------------
       Reporter:  fwclarke           |        Owner:
           Type:  defect             |       Status:  positive_review
       Priority:  major              |    Milestone:  sage-6.3
      Component:  number fields      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Vincent Delecroix  |    Reviewers:  Francis Clarke
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/vdelecroix/16147                 |  56042dcd69a3beaa1536c449682d5e95dfaf2f80
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):

 * reviewer:   => Francis Clarke


Comment:

 Replying to [comment:3 fwclarke]:
 > Does the job very neatly: positive review.

 Great! thanks!

 When you finish the review, you might better fill the reviewer field with
 your name (otherwise the release manager has extra job to do). It should
 be filled with your full name. I did it for you anyway.

 Vincent

 PS: Actually, I thought that the default answer of .abs() could be an
 element of QQbar (whenever an embedding in QQbar is defined). That way we
 would have an exact algebraic number and not an approximation. But in
 order to do that, there is something to fix with embeddings:
 {{{
 sage: K.<cbrt2> = NumberField(x^3 - 2, embedding=1)
 sage: QQbar.has_coerce_map_from(K)
 False
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/16147#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to