#16516: Faster roots computation for sparse polynomials over ZZ
-------------------------------------+-------------------------------------
       Reporter:  bruno              |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.3
      Component:  commutative        |   Resolution:
  algebra                            |    Merged in:
       Keywords:  roots, sparse      |    Reviewers:
  polynomial                         |  Work issues:
        Authors:  Bruno Grenet       |       Commit:
Report Upstream:  N/A                |  f344cdc5b4a9e316a52f5372a30a3db1ac5043ab
         Branch:                     |     Stopgaps:
  u/bruno/faster_roots_computation_for_sparse_polynomials_over_zz|
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by vdelecroix):

 7) the method `.extend()` of lists do not return anything as you can see
 {{{
 sage: [0].extend([1])
 }}}
 so there is a problem in the case algorithm "dense_with_gcd" in your
 function `_roots_univariate_polynomial`.

 8) How can you divide by the content??
 {{{
 sage: R.<x> = PolynomialRing(ZZ, sparse=True)
 sage: p = (x^7 + x^3 + 1)
 sage: p.content()
 Principal ideal (1) of Integer Ring
 sage:  (x^7 + x^3 + 1) / p.content()
 }}}

 those tow things show that you should test all cases of your code within
 the documentation!!

 Vincent

--
Ticket URL: <http://trac.sagemath.org/ticket/16516#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to