#15191: Add tests in the category of euclidean domains
-------------------------------------+-------------------------------------
Reporter: saraedum | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.3
Component: categories | Resolution:
Keywords: sd59 | Merged in:
Authors: Julian Rueth | Reviewers: Peter Bruin, Travis
Report Upstream: N/A | Scrimshaw
Branch: | Work issues:
public/ticket/euclidean_domains_tests-15191| Commit:
Dependencies: #14482, #15192 | ce64f7123ff4cc6bc7f5bf91cd670c343f0aa51c
| Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):
* reviewer: => Peter Bruin, Travis Scrimshaw
* work_issues: fix doctest failures =>
* branch: u/saraedum/ticket/15191 =>
public/ticket/euclidean_domains_tests-15191
* commit: f60c8656714e5729fbf229dcea8bb1cb64555d16 =>
ce64f7123ff4cc6bc7f5bf91cd670c343f0aa51c
Comment:
Hey Julian, I made some review tweaks. In particular, I made the test
stronger which checks the zero product property (which technically can be
moved higher up into the integral domains category). However this caused
`padic_base_leaves.py` to fail:
{{{
sage -t ../padics/padic_base_leaves.py
**********************************************************************
File "../padics/padic_base_leaves.py", line 323, in
sage.rings.padics.padic_base_leaves.pAdicRingCappedAbsolute.__init__
Failed example:
TestSuite(R).run(elements = [R.random_element() for i in range(3^6)])
Expected nothing
Got:
Failure in _test_euclidean_degree:
Traceback (most recent call last):
File "/home/travis/sage/local/lib/python2.7/site-
packages/sage/misc/sage_unittest.py", line 282, in run
test_method(tester = tester)
File "/home/travis/sage/local/lib/python2.7/site-
packages/sage/categories/euclidean_domains.py", line 93, in
_test_euclidean_degree
tester.assertFalse(p.is_zero())
File "/home/travis/sage/local/lib/python/unittest/case.py", line
416, in assertFalse
raise self.failureException(msg)
AssertionError: True is not false
------------------------------------------------------------
The following tests failed: _test_euclidean_degree
**********************************************************************
File "../padics/padic_base_leaves.py", line 414, in
sage.rings.padics.padic_base_leaves.pAdicRingFixedMod.__init__
Failed example:
TestSuite(R).run(elements = [R.random_element() for i in range(3^6)])
Expected nothing
Got:
Failure in _test_euclidean_degree:
Traceback (most recent call last):
File "/home/travis/sage/local/lib/python2.7/site-
packages/sage/misc/sage_unittest.py", line 282, in run
test_method(tester = tester)
File "/home/travis/sage/local/lib/python2.7/site-
packages/sage/categories/euclidean_domains.py", line 93, in
_test_euclidean_degree
tester.assertFalse(p.is_zero())
File "/home/travis/sage/local/lib/python/unittest/case.py", line
416, in assertFalse
raise self.failureException(msg)
AssertionError: True is not false
------------------------------------------------------------
The following tests failed: _test_euclidean_degree
**********************************************************************
2 items had failures:
1 of 11 in
sage.rings.padics.padic_base_leaves.pAdicRingCappedAbsolute.__init__
1 of 11 in
sage.rings.padics.padic_base_leaves.pAdicRingFixedMod.__init__
}}}
However IDK if this is a problem with precision with the padics or...?
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=ce64f7123ff4cc6bc7f5bf91cd670c343f0aa51c
ce64f71]||{{{Some minor review tweaks.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/15191#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
