#6882: bugs in conversion of variable names from Maxima to Sage
-------------------------------------+-------------------------------------
       Reporter:  was                |        Owner:  rws
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.3
      Component:  calculus           |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Ralf Stephan       |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/rws/bugs_in_conversion_of_variable_names_from_maxima_to_sage|  
518de3e62533cd209997107f903192f1a31d118c
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by kcrisman):

 > I also found an error in the definition for maxima variable, because it
 didn't allow variable names without '%' or the '%' not at the beginning.
 Now the mentioned rules can be expressed as simple entries in symtable.
 You'll note that `maxima_var` was never currently used in the codebase, so
 it wasn't a problem, more of just old code -
 [http://git.sagemath.org/sage.git/tree/src/sage/calculus/calculus.py#n1792
 here] is where the `%` were all replaced.  If you wanted I guess you could
 just replace that with `_` and it would be much more efficient than doing
 this whole loop every time, or so it seems to me.  How does this do with
 `timeit` for long expressions one gets in 'real life'?  (See
 sage/symbolic/random_tests.py.)  Also note that usually we end up having
 to special-case things with `%` anyway - e.g., `%ilt` (inverse Laplace
 transform) gets handled somewhere else, I'd have to look up where.

--
Ticket URL: <http://trac.sagemath.org/ticket/6882#comment:34>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to