#5771: [with patch, needs work] %latex should issue a warning if latex isn't
installed on the system
------------------------+---------------------------------------------------
Reporter: mabshoff | Owner: jhpalmieri
Type: defect | Status: assigned
Priority: major | Milestone: sage-4.0.2
Component: misc | Keywords:
Reviewer: Rob Beezer | Author: John Palmieri
Merged: |
------------------------+---------------------------------------------------
Changes (by newvalueoldvalue):
* reviewer: => Rob Beezer
* author: => John Palmieri
Comment:
This all looks good, especially since #6089 makes it so easy to add in
these checks.
I'm getting a doctest failure at line 119, the first "have_dvipng" test is
failing. I suspect some other test is setting the global variable so it
is no longer "None" and due to the way tests get re-ordered and since
there are now more tests, by the time this test is run, it will fail.
Indeed,
{{{sage -t --randorder sage/misc/latex.py}}}
can sometimes make all four of the "have_xxx" tests fail at the first
check of each group, all in the same way. So I think just the tests need
adjustment where they don't assume they are the first ones run.
If I simulate having {{{latex}}} and {{{pdflatex}}} missing, then I get
appropriate error messages. But if I run the doctests with the two
executables missing, then these error messages also bleed through in two
doctests (at line 410 and line 1565). Maybe the tests should each be
converted into two variants and somehow logically combined with the values
of {{{_have_latex}}} and {{{_have_pdflatex}}} and just return a logical
value. This doctest failure behavior is present with only #6089 applied
(i.e. without the current patch) so we have a chance to fix it before
#6089 gets merged (or we could hold it up). I hadn't thought before to
test with latex or pdflatex missing. I'm presuming we don't want test
failures just because a system does not include tex.
So I'm ready to give a positive review with adjusted doctests - everything
else looks good.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5771#comment:3>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
