#16239: ZZ in the wrong category
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: sage-combinat
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: categories | Resolution:
Keywords: integer ring, | Merged in:
category | Reviewers: Nicolas M. Thiéry
Authors: Travis Scrimshaw | Work issues:
Report Upstream: N/A | Commit:
Branch: | d9dc10517e2cef49151b77c31a2904bb4c3f4eb1
public/categories/fix_ZZ-16239 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by tscrim):
* status: new => needs_review
* commit: => d9dc10517e2cef49151b77c31a2904bb4c3f4eb1
* branch: 8c49b54c6ab7e11f6ecf6dfdf70780e74be44245 =>
public/categories/fix_ZZ-16239
Comment:
Hey Nicolas,
I remember why I had things that way:
{{{
sage: QQ in Sets().Infinite()
False
sage: MS = MatrixSpace(ZZ, 7)
sage: MS in Sets().Infinite()
False
}}}
There will be a much larger fix needed for modules over infinite base
rings recognizing that they are infinite (and `QQ` and friends will need
to be in `Sets().Infinite()`). For now, I just reverted the change and
added a comment. If that's okay for now, then can you set this back to
positive review? Thanks.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=5acdf87dd226359489572e1ef64d9a020901e517
5acdf87]||{{{Put ZZ in InfiniteEnumeratedSets.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=6acbf091ee7f4789afa45bc04ab8fee608db7b5f
6acbf09]||{{{Merge branch 'develop' into
t/16239/public/categories/fix_ZZ-16239}}}||
||[http://git.sagemath.org/sage.git/commit/?id=7dff726a81ff95fdc5f51b0f931dda66e12a0ddd
7dff726]||{{{16239: Fix Parent._list_from_iterator_cached instead of
implementing a new ZZ.list}}}||
||[http://git.sagemath.org/sage.git/commit/?id=1b4b7c61d7a6b1c578be283613bf9cc63c7f9b28
1b4b7c6]||{{{Fixed all broken doctests.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=8c49b54c6ab7e11f6ecf6dfdf70780e74be44245
8c49b54]||{{{16239: final proofreading with Travis looking over my
shoulder}}}||
||[http://git.sagemath.org/sage.git/commit/?id=a6d55364440169f2329f4c4efe6aec4214291cf9
a6d5536]||{{{Merge branch 'public/categories/fix_ZZ-16239' of
trac.sagemath.org:sage into public/categories/fix_ZZ-16239}}}||
||[http://git.sagemath.org/sage.git/commit/?id=d9dc10517e2cef49151b77c31a2904bb4c3f4eb1
d9dc105]||{{{Reverted change for check for infinite enumerated sets.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/16239#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
