#16630: Fix category for finite Coxeter groups
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: tscrim
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.3
Component: group theory | Resolution:
Keywords: Coxeter, category | Merged in:
Authors: Travis Scrimshaw | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/groups/fix_category_finite_coxeter-16630|
0f2941a9ec0dd54531a5349f10dc3c1a5ae5f1d0
Dependencies: #16633 #16634 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):
* status: new => needs_review
* commit: => 0f2941a9ec0dd54531a5349f10dc3c1a5ae5f1d0
* dependencies: => #16633 #16634
* branch: => public/groups/fix_category_finite_coxeter-16630
Comment:
Okay, it's now up for review. It feels somewhat hacky to me (in
particular, I had to catch an `OverflowError`), but it comes from Sage's
somewhat lack of ability to compute positive definiteness of a matrix over
a variety of fields. Although I do feel that checking for positive
definiteness is better than doing the matrix comparisons, at least as a
first try. meh *shrugs*
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=02752c9b79cad794024c467880feb9bd180d5bc5
02752c9]||{{{Implement a bilinear_form method and use this to check
finiteness.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=484ae916381c9dca15192c8d9209646543c73980
484ae91]||{{{Fixed _indefinite_factorization() for immutable matrix over
fields.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=6b01dd075c51428b326b26c5ff3e2c8b72d8d7e1
6b01dd0]||{{{Merge branch
'public/matrix/indefinite_factorization_immutable-16633' into
public/groups/fix_category_finite_coxeter-16630}}}||
||[http://git.sagemath.org/sage.git/commit/?id=78cfb381b90d28dcbc6301c539dd293d5910b7f2
78cfb38]||{{{Expanded conversions for real numbers.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=383632bedef64bb6d0cbaa5ac8b7e259d7f822cd
383632b]||{{{Merge branch 'public/rings/expand_RR_conversion-16634' into
public/groups/fix_category_finite_coxeter-16630}}}||
||[http://git.sagemath.org/sage.git/commit/?id=cdf6d5d2886b8587aa67acf9a59f9bb61bc9f080
cdf6d5d]||{{{Added doctests.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=0f2941a9ec0dd54531a5349f10dc3c1a5ae5f1d0
0f2941a]||{{{Some fixes for doctests.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/16630#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
