#11559: Speed up Posets and toric Chow group
-------------------------------------+-------------------------------------
       Reporter:  vbraun             |        Owner:
           Type:  enhancement        |       Status:  positive_review
       Priority:  major              |    Milestone:  sage-6.3
      Component:  algebraic          |   Resolution:
  geometry                           |    Merged in:
       Keywords:  toric, sd40.5      |    Reviewers:  Andrey Novoseltsev,
        Authors:  Volker Braun       |  Jan Keitel
Report Upstream:  N/A                |  Work issues:
         Branch:  u/jkeitel/11559    |       Commit:
   Dependencies:  #11558, #10998,    |  85a053daeadeb7a8d1de24e354cc6fc99068df7f
  #13023                             |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jkeitel):

 * status:  needs_review => positive_review
 * commit:  6cd90ca42510ca957f59363321ef24074eef1e30 =>
     85a053daeadeb7a8d1de24e354cc6fc99068df7f
 * branch:  u/chapoton/11559 => u/jkeitel/11559
 * reviewer:  Andrey Novoseltsev => Andrey Novoseltsev, Jan Keitel


Comment:

 Hi, the patch looks good to me and seems to make sensible changes.
 However, I can't tell whether the patch is actually bringing any speed
 benefits. Volker, Andrey, what exactly is it that should be benchmarked?
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=85a053daeadeb7a8d1de24e354cc6fc99068df7f
 85a053d]||{{{Nitpicking for 11559: Added a space}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/11559#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to